Skip to content

fix: remove Debian LLVM PPA repo (Linux runners only) #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Oct 18, 2024

resolves #265

Users that expect the PPA to be present after running cpp-linter-action can set the environment variable KEEP_DEBIAN_LLVM_PPA to true, on, or 1. By default, the PPA is removed.

@2bndy5 2bndy5 linked an issue Oct 18, 2024 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v12.0.0) reports: 3 concern(s)
  • build/CMakeFiles/3.31.6/CompilerIdC/CMakeCCompilerId.c:2:3: error: [clang-diagnostic-error]

    "A C++ compiler has been selected for C."

    # error "A C++ compiler has been selected for C."
      ^
  • build/CMakeFiles/3.31.6/CompilerIdC/CMakeCCompilerId.c:776:1: warning: [modernize-avoid-c-arrays]

    do not declare C-style arrays, use std::array<> instead

    char const info_version[] = {
    ^
  • build/CMakeFiles/3.31.6/CompilerIdC/CMakeCCompilerId.c:877:5: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

    int main(int argc, char* argv[])
    ~~~ ^
    auto                             -> int

Have any feedback or feature suggestions? Share it here.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Oct 18, 2024

I don't intend to get this out in the next release. I still want to test this in the test repo to be sure there is no undesired behavior or side effects.

@shenxianpeng
Copy link
Collaborator

Totally agree. As more people use it, any undesired behavior or side effects will block user work.

resolves #265

Users that expect the PPA to be present _after_ running cpp-linter-action can set the environment variable `KEEP_DEBIAN_LLVM_PPA` to `true`, `on`, or `1`. By default, the PPA is removed.
@2bndy5 2bndy5 force-pushed the rm-llvm-debian-ppa branch from 946610c to c324e4b Compare August 18, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove added LLVM apt PPA repo
2 participants